Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[.NET] Update target frameworks #265

Merged
merged 5 commits into from
Aug 15, 2024
Merged

[.NET] Update target frameworks #265

merged 5 commits into from
Aug 15, 2024

Conversation

Romfos
Copy link
Contributor

@Romfos Romfos commented Aug 9, 2024 •
edited
Loading

🤔 What's changed?

  • Drop .NET 7 from test matrix
  • Replace .NET 6 to .NET 8. because .NET 6 will reach End of Support on November 12, 2024
  • Update C# language version to 12

⚡️ What's your motivation?

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)
  • 💥 Breaking change (incompatible changes to the API)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
  • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Users should know about my change
  • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@Romfos Romfos marked this pull request as ready for review August 9, 2024 13:08
@Romfos Romfos changed the title Update target framework for .NET Update target frameworks for .NET Aug 9, 2024
@Romfos
Copy link
Contributor Author

Romfos commented Aug 9, 2024

please, squash PR during the merge

mpkorstanje
mpkorstanje reviewed Aug 9, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@Romfos Romfos requested a review from mpkorstanje August 9, 2024 13:41
@mpkorstanje
Copy link
Contributor

Cheers. I'm waiting for a review from either @gasparnagy or @clrudolphi.

Context: cucumber/messages#237 (comment)

gasparnagy
gasparnagy approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@gasparnagy gasparnagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx. I'm OK with this changes.

@gasparnagy
Copy link
Member

@mpkorstanje these changes are "technically" breaking changes, but in practice they will not break any code, because we still have the support for ".NET Standard 2.0" which anyway covers all those older frameworks that are now removed from the "direct" support.

@mpkorstanje mpkorstanje changed the title Update target frameworks for .NET [.NET] Update target frameworks Aug 15, 2024
@mpkorstanje mpkorstanje merged commit 3970e02 into cucumber:main Aug 15, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clrudolphi clrudolphi clrudolphi approved these changes

@gasparnagy gasparnagy gasparnagy approved these changes

@mpkorstanje mpkorstanje Awaiting requested review from mpkorstanje

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Romfos @mpkorstanje @gasparnagy @clrudolphi